Skip to content

feat: Don't enforce a renderer for subclasses of HTMLElement #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeworrior wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

feat: Don't enforce a renderer for subclasses of HTMLElement #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/linter/ui5Types/SourceFileLinter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ export default class SourceFileLinter {

// Special cases: Some base classes do not require sub-classes to have a renderer defined:
if (this.isUi5ClassDeclaration(node, [
"sap/ui/core/html/HTMLElement", // since 1.153
"sap/ui/core/mvc/View",
// XMLComposite is deprecated, but there still shouldn't be a false-positive about a missing renderer
"sap/ui/core/XMLComposite",
Expand Down
12 changes: 9 additions & 3 deletions test/fixtures/linter/rules/renderer/ControlRendererDeclaration_negative.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
sap.ui.define([
"sap/ui/core/Control", "sap/m/Button", "sap/ui/core/webc/WebComponent",
"sap/uxap/BlockBase", "./NegativeExample1Renderer", "sap/ui/core/mvc/View",
"sap/ui/core/XMLComposite", "sap/f/cards/loading/PlaceholderBaseRenderer"
], function(Control, Button, WebComponent, BlockBase, NegativeExample1Renderer, View, XMLComposite, PlaceholderBaseRenderer) {
"sap/ui/core/XMLComposite", "sap/f/cards/loading/PlaceholderBaseRenderer",
"sap/ui/core/html/HTMLElement"
], function(Control, Button, WebComponent, BlockBase, NegativeExample1Renderer, View, XMLComposite,
PlaceholderBaseRenderer, HTMLElement) {

const NegativeExample1 = Control.extend("sap.ui.demo.linter.controls.NegativeExample1", {
metadata: {},
Expand Down Expand Up @@ -58,7 +60,7 @@ sap.ui.define([
// No deprecation: Uses inline renderer of XMLComposite if no renderer is specified
// Note: XMLComposite itself is deprecated, but there should not be a finding for a missing renderer
});

const NegativeExample13 = Control.extend("sap.ui.demo.linter.controls.NegativeExample13", {
metadata: {},
// No deprecation: sap/f/cards/loading/PlaceholderBaseRenderer
Expand All @@ -67,4 +69,8 @@ sap.ui.define([
renderer: PlaceholderBaseRenderer,
});

const NegativeExample14 = HTMLElement.extend("sap.html.Span", {
metadata: {},
// No deprecation: Uses renderer inherited from HTMLElement
});
});