Samples groups from sample groups #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix: - moves the button from being inline with the list description text to down near the samples list - shows a button even when there are a small number of samples so the user can still show/hide the study labels - saves the hide/show study labels variable per user so they only have to show/hide them once per the user's preferences
- add sample/feature_labels to SG schema - populate those attributes in the creation method
The tricky is that Semantic UI is really bad at handling stickies when the sticky is taller than the containing element. The solution is to destroy the sticky when it's taller than the containing element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the creation of sample groups using other sample groups as a source. This also includes minor UI redesigns for the sample group creation page.
This PR is dependent on changes introduced by #59 and actually forks off that branch, so that PR should be merged before this one is reviewed.
See here for a discussion of the schema changes introduced by this change. Essentially, the
data_setsfield in a sample group now just lists where the samples are from, while thefiltered_sample_sourceslists how the samples were added to the sample group.The
sample_groups_from_sample_groups.jsmigration must be run before this code goes live.