Sync time on raspberry pi before running setup script#3618
Merged
StarrryNight merged 12 commits intoUBC-Thunderbots:masterfrom Feb 28, 2026
Merged
Sync time on raspberry pi before running setup script#3618StarrryNight merged 12 commits intoUBC-Thunderbots:masterfrom
StarrryNight merged 12 commits intoUBC-Thunderbots:masterfrom
Conversation
added 2 commits
February 20, 2026 11:13
annieisawesome2
previously approved these changes
Feb 21, 2026
annieisawesome2
previously approved these changes
Feb 21, 2026
suchirss
reviewed
Feb 22, 2026
suchirss
reviewed
Feb 22, 2026
suchirss
reviewed
Feb 22, 2026
suchirss
reviewed
Feb 22, 2026
suchirss
requested changes
Feb 22, 2026
Contributor
suchirss
left a comment
There was a problem hiding this comment.
Looks great for the normal case (no tags configured in the command to run setup_pi)! Left notes for a few changes regarding tags, idempotency, and a naming nit.
Contributor
Author
|
Thanks Suchir. I will fix the naming nits and add change the tag to dependencies since its a better fit. And also add the checking ntp block and only enabling if its disbaled. |
Contributor
|
Thanks for applying my requested changes. Your task is now maintains idempotency + correctly applies only the I ran the following test cases and all of them behaved as expected. The testing also spurred issue #3627 LGTM + nice work! |
suchirss
approved these changes
Feb 28, 2026
williamckha
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR resolve #3615 . It adds an ansible task to enable ntp before running the setup_pi.yml script to ensure time in synced with local machine.
After enabling ntp, the time on the raspberry pi synced to the local machine. This enabled the setup script to run correctly.

Set up pi.

Description
Testing Done
Resolved Issues
#3615
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue