Repository navigation
Conversation
mrcwbr
force-pushed
the
fix/accessor-deprecated-detection
branch
from
October 26, 2026 06:54
9e51442 to
d3c6aca
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflection.isDeprecated()only inspects declaration.signatures, which is populated for methods and functions. Accessors (get/set) never populate signatures — their doc comments live on the separategetSignature/setSignature properties instead. As a result, a
@deprecatedtag on a getter or setter was silently ignored:isDeprecated()returned false, and anything downstream that relies on it (e.g.typedoc-plugin-markdown striking through deprecated titles) never picked it up.
This adds the same "every signature deprecated" check already used for signatures to getSignature/setSignature, so an accessor is considered deprecated only when all of its defined accessors (get
and/or set) carry
@deprecated— consistent with how overloaded methods are already handled.