Added support for ints, uints and float32#2
Open
bt wants to merge 2 commits into
Open
Conversation
|
Could this be merged @TylerBrock ? |
Owner
|
Ah yeah, sorry for the delay. I might be able to spend some time on PRs this week. Stay tuned. |
Owner
|
It doesn't look like we can merge this one as is because of the included go.mod. I'm also on the fence for including this functionality as the library is meant to print unmarshalled json... I'll have to think on that a bit. |
Author
Understood, hence I mentioned in my PR. Let me know if you'd like me to remove the |
Owner
|
Yes please do, lets start there and review what’s left.
On Wed, Jan 26, 2022 at 10:51 PM Bertram Truong ***@***.***> wrote:
It doesn't look like we can merge this one as is because of the included
go.mod.
I'm also on the fence for including this functionality as the library is
meant to print unmarshalled json... I'll have to think on that a bit.
Understood, hence I mentioned in my PR.
Let me know if you'd like me to remove the go.mod for the merge, if you'd
accept.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACERZYUYEDFRMNI6FR6RYLUYC6NPANCNFSM4G72YEBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
…-Tyler
|
Author
Done! The Let me know if there's any further requirements for the PR and I'll see what I can do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for various
intanduinttypes, as well asfloat32.I understand that your library was targeting unmarshalled JSON structs, so this might not be in scope. I am using
colorjsonto pretty-print my structs for debugging purposes and noticed that since these types aren't implemented, they return as an empty string in the output.Also, unsure if there's a better way to implement this; Golang doesn't seem to like grouping
int/uinttypes together and then type casting, so I have to make a case for each. The other option would of course be to usereflectbut it's quite a bit slower.