fix: adds Svelte and Next.js#389
Draft
HashMapsData2Value wants to merge 3 commits intoTxnLab:mainfrom
Draft
Conversation
Contributor
Author
|
Just need to address a CORS issue in the Liquid Auth backend, which you experience when you try to press "Disconnect" in one of the example apps running on localhost. Anyone hosting their own Liquid Auth backend with use-wallet on a page, all on their own domain, should not be experiencing that problem. Furthermore, it is possible to disconnect by refreshing the page. |
chore: prettier
HashMapsData2Value
force-pushed
the
fix/add-svelte
branch
from
5f3f2b7 to
4e27830
Compare
Collaborator
|
@HashMapsData2Value as we discussed, Liquid Auth as been removed temporarily until the peer dependency issues are sorted out. Since they affect production dApp builds even if the Liquid Auth provider is not configured, this is a necessary step until the issue(s) are resolved. I'll keep this PR open so it can be merged after the Liquid Auth provider has been restored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades liquid auth use-wallet-client version to make Svelte work.
ETA: after trying with Next.js and discovering that it also works, I'm re-adding it.