Skip to content

feat: Discord-style voice channel click-to-join with chat button#2

Merged
Trifall merged 4 commits into
Trifall:mainfrom
ajlittle:feat/voice-channel-click-to-join
Mar 3, 2026
Merged

feat: Discord-style voice channel click-to-join with chat button#2
Trifall merged 4 commits into
Trifall:mainfrom
ajlittle:feat/voice-channel-click-to-join

Conversation

@ajlittle

@ajlittle ajlittle commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Clicking a voice channel name in the sidebar now automatically joins the voice call and navigates to the channel (like Discord)
  • Won't disconnect/reconnect if you click a channel you're already in
  • Added a chat bubble hover action on voice channels to open the text chat without joining voice
  • Keeps the existing header bar join button from PR feat: Mobile UI for web stoatchat/for-web#835

@ajlittle ajlittle changed the title feat: click voice channel name to join call (Discord-style) feat: click voice channel name to join call Mar 1, 2026
@ajlittle ajlittle changed the title feat: click voice channel name to join call feat: Discord-style voice channel click-to-join with chat button Mar 1, 2026
Clicking a voice channel name in the sidebar now automatically joins
the voice call and navigates to the channel text chat.

Added a chat bubble hover action on voice channels to open the text
chat without joining voice.
@Pecacheu

Pecacheu commented Mar 2, 2026

Copy link
Copy Markdown

Good idea, but this won't work on the mobile UI since hover action menus don't work with touchscreens. To solve that, you can add a matching action to ChannelContextMenu.tsx

Also side note, this creates a small merge conflict with my PR because I lifted the href out of the a tag and made it part of MenuButton (which was done in order to run some extra code in onClick so that clicking any channel/DM triggers an automatic swipe from channel view to message view.) Luckily the onClick listener can be applied to MenuButton instead because I have some code in there that calls the original onClick listener too if specified.

@ajlittle

ajlittle commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator Author

I wasn't really thinking from a mobile perspective on this. But from a UX perspective, having this current implementation on a touch device may lead to accidental joining of voice channels.

Probably best to be handled by a confirmation prompt that they would like to join the channel, like discord has. @Pecacheu

Signed-off-by: Jerren T <JerrenT@Trifall.com>
@Trifall Trifall merged commit 874219b into Trifall:main Mar 3, 2026
1 check failed
@ajlittle ajlittle deleted the feat/voice-channel-click-to-join branch March 3, 2026 00:06
Trifall pushed a commit that referenced this pull request Mar 16, 2026
Voice UI improvements and CF Pages build setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants