add else to avoid concatenate bug#433
Open
Xploeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduce and Detailed Description
Issue #432 explains the bug and has a script to reproduce it.
Bug Report
The model instantiators are bugged if you try to use "concatenate" in the output definition. Something like this:
Error is:
Root cause: In _parse_output (common.py), the visit_Call method of the NodeTransformer replaces node.func with an ast.Attribute node when it encounters concatenate, but then falls through to the activation function check which assumes node.func is still an ast.Name (i.e. has .id).
Fix
Add an
elseafter the "concatenate" block so the activation function translation is skipped if the node is a concat.This analogous to
_parse_inputwhich has anelif ...after theif node.func.id == "concatenate":block