Update memory_index once per batch, not per tensor#328
Open
AlexD15216 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The write pointer was being incremented inside the for-loop that iterates
over every tensor in the batch. When more than one tensor is present (common situation in RL), this
advanced the pointer multiple times for the same batch, leaving gaps and
eventually skipping slots in the ring buffer.
Because all tensors share the same first dimension (batch size), the
pointer should move once after the entire batch has been copied.
The increment logic is now placed after the loop so the index grows
by
num_samplesexactly once.