Reset modal after adding event

[romanstetsyk]

Description

Reset the form after adding an event by clicking the 'close' button or clicking on the modal backdrop.

Type of change

Please select everything applicable. Please, do not delete any lines.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• This change requires an update to testing

Issue

• Is this related to a specific issue? If so, please specify: Create event modal fails to reset without user input #425

Checklist:

• This PR is up to date with the main branch, and merge conflicts have been resolved
• I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
• I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings

[intelagense]

Good job. This should do the trick while we wait to start on a redesigned event modal. 👍

[cblanken]

I don't think this conditional should silently pass if a "function" typed onBackdropClick isn't passed as a prop.

If someone is adding more modals later but accidentally passes an onBackdropClick of some type other than "function", this if will essentially hide that error.

Instead, it might be better to just check for the existence of onBackdropClick. Then if a non-function prop is passed to Modal it will easily be caught during testing.

Suggested change

	if (typeof onBackdropClick === "function") onBackdropClick();
	if (onBackdropClick) onBackdropClick();

[cblanken]

Optionally you could add a check for the onBackdropClick type with prop-types. That way you get an error on page load if an invalid onBackdropClick prop is passed in instead of at runtime.

Suggested change

	import PropTypes from "prop-types";
	// Modal component definition
	Modal.propTypes = {
	onBackdropClick: PropTypes.func,
	};

Like this

[cblanken]

If a redesign for the event modal is in the works like @intelagense mentioned then this may not be that important. Just my two cents.

[Caleb-Cohen]

If a redesign for the event modal is in the works like @intelagense mentioned then this may not be that important. Just my two cents.

I'm not sure the redesign will be coming anytime soon.