Conversation
sbordeyne
approved these changes
Mar 29, 2020
Member
sbordeyne
left a comment
There was a problem hiding this comment.
Didn't have time to review until now, but I've reviewed it and I don't see anything wrong with this, so I approved for merging.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains changes that will improve the existing
Balloonwidgets and refactors it into theTooltipwidget. This branch is thetkinterpp-tooltipbranch but rebased so that it only contains this widget and no other changes.The
parse_geometry_stringoverlaps functionality with a function introduced in PR #48 , so PR #48 should be merged before this one and then this one rebased on top of the new master so as to avoid having two functions which do the same thing. No tests are included for this function for this reason.The changes in this PR are inspired by the functionality of @dogeek's tooltip widget. The new functionality includes:
showheaderto allow the user to hide the header of the tooltipstaticto allow static placement of the tooltip relative to the master widget rather than position relative to the mouse position within the widgetoffsetto allow setting an offset from the position of the mouse or the master widget to show the tooltipThis is the PR for issue #39.