AutocompleteCombobox: Optional sorting#113
Open
masonhfisher wants to merge 3 commits intoTkinterEP:masterfrom
Open
AutocompleteCombobox: Optional sorting#113masonhfisher wants to merge 3 commits intoTkinterEP:masterfrom
masonhfisher wants to merge 3 commits intoTkinterEP:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 89.53% 86.68% -2.85%
==========================================
Files 43 43
Lines 4032 4154 +122
==========================================
- Hits 3610 3601 -9
- Misses 422 553 +131
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sbordeyne
previously approved these changes
Oct 3, 2025
Member
|
If you could add a small test to keep coverage stable, that would be great |
…fix of unintended behaviour
sbordeyne
approved these changes
Oct 4, 2025
Member
sbordeyne
left a comment
There was a problem hiding this comment.
Looks good to me, the coverage drop seems unrelated from looking at the more detailed codecov report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small patch for the
ttkwidgets.autocomplete.AutocompleteComboboxthat adds an argument to the initializer method that allows the user to decide if they want their list to be sorted automatically or not.The option to sort automatically is set to True by default to maintain backwards compatibility with older versions of ttkwidgets.
The patch is made for the reason that sometimes you probably don't want your list to be sorted (like for example in my case, a list of months).