v1.9.1#249
Merged
Merged
Conversation
Update Translations
Add support for additional audio formats (.wav, .ogg, .opus, .flac) across uploads and media listings; sanitize uploaded filenames. Introduce a unified audio proxy (ttscast.audio.proxy.php) with distinct handling for tts (cache) and sounds/customsounds (media folder) and stricter filename validation. Update daemon to use the proxy URL, quote filenames, detect mime type by extension and set media_type accordingly. Update UI accept/tooltip, bump pluginVersion to 1.9.1, and rename config key to ttsWebSrvMediaProxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for multiple audio file formats (mp3, wav, ogg, opus, flac) throughout the TTS Cast plugin, improving flexibility for users uploading and playing custom sounds. It also updates the backend and proxy logic to safely handle these new file types, and modifies the Python daemon to use a proxy endpoint for serving audio files with correct MIME types.
Audio Format Support and Validation:
.wav,.ogg,.opus, and.flacin addition to.mp3, and updated validation and error messages accordingly inttscast.ajax.phpand the plugin configuration UI. [1] [2]getSoundList()andgetCustomSoundList()to list all supported audio file types, not just.mp3. [1] [2]File Handling and Security:
basename) to prevent directory traversal, and updated the proxy script (ttscast.audio.proxy.php) to validate file names and extensions for all supported formats and request types. [1] [2]Proxy and Daemon Integration:
ttscastd.py) to use a new proxy endpoint (ttsWebSrvMediaProxy) for serving both standard and custom sounds, passing the filename and type as query parameters and encoding filenames safely. [1] [2] [3]Miscellaneous:
info.json.ttscastd.pyforquotefromurllib.parse.