UI improvements: panel reactivity, drag preview, area card & rename fix#23
Merged
UI improvements: panel reactivity, drag preview, area card & rename fix#23
Conversation
Tunes DndContext autoScroll threshold to 5% from edge (was 20%) so the Areas panel no longer scrolls when dragging a habit toward the Cycle panel below.
MomentStack registers draggables as 'stack-{momentId}' but DnDProvider
was looking up allMoments[activeId] with that raw string, returning null.
Now extracts the real momentId from data.current.momentId so the overlay
renders correctly when dragging from the CycleDeck to the Timeline.
- Add cycleDeckCollapsed$ observable to ui-store (mirrors drawingBoardExpanded$ pattern) - Add chevron toggle button to CycleDeck header (shows only header when collapsed) - Update p hotkey to toggle CycleDeck when active cycle is present, DrawingBoard otherwise - Update CycleDeck tests to mock all three useValue calls correctly
EmptyAreaCard: - Replace oversized circle+text layout with a compact dashed-border card - Header matches PlanAreaCard height for visual consistency - Small square + icon replaces the large circle - Cleaner hover states using stone tones only PlanAreaCard: - Fix handleSaveName to also save when only tags changed (previously only saved when area name changed, losing tag edits entirely)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DndContextautoScroll threshold from 20% to 5% so the Areas panel no longer yanks upward when dragging a habit toward the Cycle panelMomentStackuses"stack-{momentId}"as its dnd-kit ID but the overlay was doingallMoments[activeId]which returned null. Now extracts the realmomentIdfromdata.current.momentIdso the card preview appears during dragphotkey — Added chevron button in CycleDeck header and acycleDeckCollapsed$observable. Thephotkey now toggles CycleDeck when an active cycle is present, and DrawingBoard otherwise (they're mutually exclusive)handleSaveNamewas only persisting changes when the area name changed. Tag-only edits were silently dropped. Now saves whenever name OR tags differ from the stored valuesTest Plan
pwith an active cycle — CycleDeck should collapse/expand; chevron button in header should also togglepwith no active cycle — DrawingBoard should still toggle as before🤖 Generated with Claude Code