Repository navigation
Filter the expired-domain table, and stop claiming sources that never ran - #57
Merged
Merged
Conversation
… ran Two problems the first real run exposed on a project with no saved competitors. The link-gap source returned an empty list instead of erroring, so it was counted in sourcesUsed and the summary reported "50 checked" as though every source had searched. It had not: link gap is the source that reaches ADJACENT domains -- a food or nutrition site linking to a vending competitor -- so without it the run collapses to SERP rivals and returns more of the same vertical. A source now declares why it cannot run, is recorded as skipped rather than used, and is never invoked, so a metered source cannot fire as a no-op. The panel names what was not searched and points at the fix. And the table had no way to answer "which of these can I actually buy". Status filters plus a domain search now narrow it client-side, over rows already paid for, so changing a filter never re-requests anything. Filtering to nothing says so distinctly from finding nothing -- the two states looked identical before.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
flyrocketseo | 69ec75d | Aug 20 2026, 04:35 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both problems came out of the first real run, on the Delio project.
The results were thin, and the panel hid why
Every row said "ranks for N of your keywords" — none said "links to N of your competitors". Link gap contributed nothing, because Delio has 0 competitors saved. That source returned an empty list rather than erroring, so
collectCandidatescounted it insourcesUsedand the summary reported "50 checked" as though everything had searched.That matters more than it sounds: link gap is the source that reaches adjacent domains — a food or nutrition site that links to a vending competitor. Without it the run collapses to SERP rivals over the project's own tracked keywords, which by construction returns more of the same vertical. The output looked like a weak feature; it was actually a feature running on one leg and not saying so.
Now a source declares
unavailableReason(context). When it cannot run it is recorded as skipped, not used, andcollectis never invoked — so a metered source can never fire as a billed no-op. The panel names what was not searched and points at the fix:No way to ask "which of these can I actually buy"
Status filters (All / Expired only / Expires soon / This quarter) plus a domain search box. Filtering is client-side over rows already paid for, so changing a filter never re-requests anything. "Filtered to nothing" now reads differently from "found nothing" — those two states were indistinguishable.
Verification
pnpm ci:checkclean;pnpm testgreen — 307 files, 3104 tests.sourcesSkipped, neversourcesUsed, and itscollectis not called.e2e/expired-domains.spec.tsstill passes: panel mounts idle, quotes its ceiling, zero metered requests before a click.sourcesSkippeddefaults to[]so runs recorded before this change still parse.Still not solved by this PR
Adjacency is only as wide as the candidate sources. With competitors saved, link gap does the work. Reaching genuinely unconnected expired domains in a niche still needs a drop-list feed (DomCop / ExpiredDomains.net) — a second vendor, still out of scope.
🤖 Generated with Claude Code