Repository navigation
Seed SERP-rivals from rank-tracked keywords - #55
Merged
Merged
Conversation
Those are the queries the user has explicitly said they care about, which makes them the most defensible answer to "who else competes here" -- saved keywords are a research bucket and GSC queries include plenty the project never targeted. Keywords live per tracking config, so they are gathered across the project's configs and deduped: the SERP endpoint bills PER KEYWORD, so the same keyword tracked under two configs must not be paid for twice. A rank-tracking read that fails degrades to no seed rather than taking down a run whose other two sources are fine. Also corrects the panel's cost line, which now understated the bill. It claimed "one DataForSEO link-gap lookup"; a run makes two DataForSEO calls, and the second is priced per keyword. The e2e spec asserts the corrected wording, so the quote cannot silently drift from what the code actually spends again.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
flyrocketseo | 251e3e6 | Aug 20 2026, 02:31 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the third candidate source in the expired-domain finder. It was built and tested in #52 but returned nothing without a keyword seed.
Why rank-tracked keywords
They are the queries you have explicitly said you care about. Saved keywords are a research bucket (plenty get saved and never pursued), and GSC queries include everything you happen to rank for rather than what you target. A caller can still override via the
keywordsinput.The cost correction that came with it
The SERP endpoint is priced per keyword, so this adds real DataForSEO spend to a run. The panel previously said "Also runs one DataForSEO link-gap lookup" — that now understates the bill. It reads "two DataForSEO lookups: one link-gap call, and one SERP call priced per rank-tracked keyword", and the e2e spec asserts that wording so the quote cannot silently drift from what the code actually spends.
Keywords are gathered across the project's tracking configs and deduped — the same keyword tracked under two configs must not be billed twice. A rank-tracking read that fails degrades to no seed rather than taking down a run whose other two sources are fine.
Verification
pnpm ci:checkclean;pnpm testgreen — 306 files, 3092 tests.e2e/expired-domains.spec.tspasses, including the new cost-copy assertion. Still needs no API key and no guard, so it runs on every CI run.Not verified
A run that actually uses the seed is not browser-verified — that bills DataForSEO per keyword plus APIVerve per candidate.
Deploy notes
No D1 migration.
🤖 Generated with Claude Code