Make CI able to pass, so it can start gating - #11
Merged
Conversation
This workflow has produced ZERO runs in this repository. It arrived with the fork (upstream PRs every-app#162, #31) and, had it ever fired, every run would have been red: three steps ran `pnpm --dir web ...` against the marketing site that was deleted during de-branding, so `install` would fail on a missing directory. Removed those three steps. Verified the remaining ones with the exact scripts CI invokes: `pnpm install --frozen-lockfile` is in sync (pnpm pinned at 10.30.1, matching Dockerfile.selfhost), `ci:check` is clean, and `test:ci` passes 2,087 tests. No build step added on purpose. The Cloudflare "Workers Builds" check already builds every PR and `ci:check` runs `tsc --noEmit`, so building here would be a third pass over the same work. What this workflow uniquely adds is prettier, knip, oxlint and the test suite -- none of which Workers Builds runs, which is why every quality claim on the Phase 1 branch had to be made by hand. Added workflow_dispatch so it can be triggered from the Actions tab without opening a throwaway PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
flyrocketseo | 242e56f | Jul 30 2026, 05:31 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.ymlhas produced zero runs in this repository. It arrived with the fork (upstream PRs every-app#162, #31) and — had it ever fired — every run would have been red: three steps ranpnpm --dir web ...against the marketing site deleted during de-branding, soinstallwould fail on a missing directory.Changes
web/steps.workflow_dispatchso it can be kicked from the Actions tab without opening a throwaway PR.ci:checkrunstsc --noEmit. Addingpnpm run buildwould be a third pass over the same work.Verified locally with the exact scripts CI invokes
pnpm install --frozen-lockfileDockerfile.selfhost)pnpm run ci:checkpnpm run test:ciWhy this matters more than another feature
Every quality claim on the Phase 1 branch (#10) was made by me running these by hand. The only automated check was Workers Builds, which does not run prettier, knip, oxlint or the test suite. Three adversarial review passes on that branch each found regressions introduced by the previous pass's fixes — that is exactly the failure mode automated gating catches cheaply.
Open question this PR answers empirically
If CI still does not appear on this PR, the workflow is blocked by GitHub's fork-level Actions gate rather than by the file, which needs a one-time manual enable in the Actions tab.
docker-buildis left as-is:Dockerfile.selfhostis still in the tree and self-contained. If Docker self-hosting is dead, the right cleanup is deleting the Dockerfile and the job together — a separate call.🤖 Generated with Claude Code