Fix(searches): Correct column pointer initialization in RowColumnWiseSorted2dArrayBinarySearch - #6333
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6333 +/- ##
=========================================
Coverage 74.33% 74.33%
Complexity 5391 5391
=========================================
Files 679 679
Lines 18820 18820
Branches 3646 3646
=========================================
Hits 13989 13989
Misses 4274 4274
Partials 557 557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codingmydna
force-pushed
the
fix/2d-array-search-bug
branch
from
July 1, 2025 13:17
41292a7 to
6ca8592
Compare
DenizAltunkapan
previously approved these changes
Jul 1, 2025
DenizAltunkapan
left a comment
DenizAltunkapan
left a comment
Member
There was a problem hiding this comment.
Why created as Draft? Looks good to me.
Contributor
Author
I thought it didn't pass a CI check, |
codingmydna
marked this pull request as ready for review
July 2, 2025 00:34
codingmydna
requested review from
BamaCharanChhandogi,
alxkm,
siriak,
vil02 and
yanglbme
as code owners
July 2, 2025 00:34
siriak
reviewed
Jul 2, 2025
codingmydna
force-pushed
the
fix/2d-array-search-bug
branch
from
July 2, 2025 10:36
3dd5491 to
bae6cc9
Compare
siriak
enabled auto-merge (squash)
July 2, 2025 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.javaCloses #6332
This pull request fixes a bug in the
RowColumnWiseSorted2dArrayBinarySearch.javafile where the column pointer was incorrectly initialized.The Problem:
The column pointer (
colPointer) was being initialized withmatrix.length - 1. However,matrix.lengthreturns the number of rows, not columns. This causes the algorithm to start at an incorrect position and fail for any matrix that is not square.The Solution:
I have corrected the initialization to
int colPointer = matrix[0].length - 1;. This correctly uses the length of the first row to determine the number of columns, ensuring the pointer is set to the last column's index as intended by the algorithm's logic.