ci: a fork can pass the release check, and absent provenance cannot - #2146
Merged
The01Geek merged 1 commit intoAug 29, 2026
Merged
Conversation
Two defects in this repository's required check, both in its artifact verification step. A pull request from a fork could never pass it. The exemption that skips artifact verification for an ordinary pull request was gated on the pull request coming from this repository, so a fork matched no arm, fell through to full verification, and failed on every file it changed. That gate was collateral from the v2.38.1 fork-bypass fix, whose actual subject is the judge-comparison step above -- untouched here, and still refusing any fork that edits the verifier. Skipping grants a fork exactly what a same-repository pull request already gets, and it reduces candidate code execution, since a fork no longer reaches the verifier invocation. A tree carrying no provenance reported success. The guard refusing an absent .release/source.json keyed on the branch name alone, and a push carries the branch name "main" rather than a release/* name -- so deleting that one file turned this check green on the published branch. A pull request that deletes provenance the base carries is now refused as well. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The01Geek
deleted the
policy-update/fork-ordinary-pr-and-provenance-guard
branch
August 29, 2026 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A judge change, so it lands as its own
policy-update/*pull request carrying only.github/workflows/distribution-verify.yml— evaluated by the base branch's verifier.1. A fork could never pass the required check
The exemption that skips artifact verification for an ordinary pull request was gated on the pull request coming from this repository. A fork matched no arm, fell through to full verification, and failed on every file it changed — so every outside contribution showed a permanently red required check it could do nothing about.
That gate was collateral from the v2.38.1 fork-bypass fix. The hole that fix closed is in the judge-comparison step above, which this change does not touch: its exemptions remain gated on same-repository origin, so a fork still cannot introduce or edit the verifier that judges it.
Skipping grants a fork exactly what a same-repository pull request already gets. It also reduces candidate code execution — a fork no longer reaches the verifier invocation at all.
2. A tree carrying no provenance reported success
The guard refusing an absent
.release/source.jsonkeyed on the branch name alone. A push carriesmain, not arelease/*name, so deleting that one file turned the whole check green on the published branch. A pull request that deletes provenance the base carries is now refused too.Verification
The step's real
runblock was extracted from the YAML and executed across the matrix:main, no provenancerelease/*, no provenancerelease/*pull request, any originmain, provenance presentThat last row is the pre-first-release bootstrap the guard promises, and it is preserved.
Expected consequence
This edits a file
.release/files.sha256covers without regenerating it, somainwill fail its own check from this merge until the next release republishes.release/. That is the known, self-healing policy-update window, and the release follows immediately.