Skip to content

Fix MSVC warnings #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beachtom merged 1 commit into from
Sep 18, 2026
+9 −6
Merged

Fix MSVC warnings #2192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cpp/web-ifc/geometry/operations/boolean-utils/shared-position.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ namespace fuzzybools

auto GetSegments() const
{
const auto makeSegments = [&](int i)
const auto makeSegments = [&](size_t i)
{
return std::make_pair(points[i - 1].second, points[i].second);
};
Expand Down
5 changes: 4 additions & 1 deletion src/cpp/web-ifc/modelmanager/ModelManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ webifc::parsing::IfcLoader *webifc::manager::ModelManager::GetIfcLoader(uint32_t
const webifc::manager::LoaderSettings &webifc::manager::ModelManager::GetSettings(uint32_t modelID) const
{
if (!IsModelOpen(modelID))
return LoaderSettings();
{
static const LoaderSettings defaultSettings;
return defaultSettings;
}
return _settings[modelID];
}

Expand Down
8 changes: 4 additions & 4 deletions src/cpp/web-ifc/parsing/IfcTokenStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ namespace webifc::parsing
return true;
}

bool IfcTokenStream::SetTokenSource(std::istream &requestData)
{
return SetTokenSource([&](char* dest, size_t sourceOffset, size_t destSize) { requestData.seekg(sourceOffset); requestData.read(dest, destSize); return requestData.gcount();},true);
}
bool IfcTokenStream::SetTokenSource(std::istream &requestData)
{
return SetTokenSource([&](char* dest, size_t sourceOffset, size_t destSize) { requestData.seekg(sourceOffset); requestData.read(dest, destSize); return static_cast<uint32_t>(requestData.gcount());},true);
}

std::string_view IfcTokenStream::ReadString()
{
Expand Down