Fix inverted Charge From Grid switch state on refresh - #17
Merged
Conversation
site_info updated the On characteristic with the raw disallow_charge_from_grid_with_solar_installed value, while SET sends its inverse. Apply the same inversion on read so refreshed state matches what SET produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
chargefromgrid.ts'ssite_infolistener wrote the rawdisallow_charge_from_grid_with_solar_installedvalue straight to theOncharacteristic, while theonSethandler treats the switch as the inverse of that API value (!value) when sending commandson.updateValue(!data.components.disallow_charge_from_grid_with_solar_installed)) so refreshed state matches SET semantics