fix(uninstall): remove MCP servers before deleting managed-mcp.json - #253
Merged
Conversation
Uninstall called reconcileMcp with removeAll after executeRemoval had already deleted ~/.teamai/, so the ownership manifest was gone and the cleanup became a no-op. Run MCP removal first, matching how hooks use the managed-hooks manifest before the home directory is removed.
Drive the real CLI against an offline HOME sandbox: inject a team server, uninstall, and assert the managed entry is gone while a hand-added server and the rest of ~/.claude.json stay. Catches the order bug where removeAll ran after managed-mcp.json was already deleted.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uninstall intended to clean teamai-managed MCP servers via
reconcileMcpForConfig(..., { removeAll: true }), but that call ran afterexecuteRemovaldeleted~/.teamai/(which holdsmanaged-mcp.json). With an empty manifest,removeAllearly-returns and leaves servers in~/.claude.json/~/.cursor/mcp.json/ etc.Hooks already avoid this by reading
managed-hooks.jsoninsideexecuteRemovalbefore the home directory is removed. MCP cleanup now runs first for the same reason.Test plan
mcp inject→uninstall --force→ team server gone, user server kept,~/.teamairemovednpx vitest run src/__tests__/uninstall.test.tsnpx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/mcp-uninstall.test.ts