fix(import): address review findings for progress bar PR#127
Merged
Conversation
- P0: Change exitOnError from false to true in --from-mr listr2 config (prevents silent error swallowing) - P1: Add backward compat for old Chinese marker '## AI 架构叙事' in overview.md idempotent replacement - P1: Add setSilent(true) around listr2 tasks.run() to prevent ora spinner conflicts with listr2 renderer in TTY mode - P2: Use explicit LearningDraft | undefined type for ctx.learning instead of unsafe 'as unknown' cast - P2: Use task.title instead of task.output for failure message in Task 2, so listr2 doesn't show misleading green checkmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for PR #117 (progress bar) that was merged before review fixes landed.
exitOnError: false→truein --from-mr listr2 config (errors were silently swallowed)## AI 架构叙事in overview.mdsetSilent(true)around listr2 to prevent ora/listr2 TTY conflictLearningDraft | undefinedtype for ctx.learningtask.titleinstead oftask.outputfor failure messageTest plan
🤖 Generated with Claude Code