fix const-correctness of ConstantFlag::operator-> - #190
Merged
Conversation
Owner
|
Good call, and good fix. It makes sense to me. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken operator-> on ConstantFlag
The arrow operator is a const member yet returns
&valueas a plainT*; inside a const method that address has typeconst T*, so the conversion is ill-formed and anyconstantFlag->memberfails to compile. It stayed hidden because this is the onlyoperator->on the class and the shipped test only reachesGet()through aConstantFlagpointer, so the member operator is never instantiated.Every other value type here already pairs a mutable
T*overload with a constconst T*one, and a constant only needs the const form, so returningconst T*lines it up with the rest. The test now reaches into a struct-typed constant through the arrow, which fails to build on master and passes with the change.