Skip to content

fix: empty ORLists now return false #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBobBobs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: empty ORLists now return false #1297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32f73a
fix: empty ORLists now return false
TheBobBobs Jan 21, 2026
38de398
fix: replace invalid tags with false when building sql query
TheBobBobs Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/tagstudio/core/library/alchemy/visitors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from typing import TYPE_CHECKING, override

import structlog
from sqlalchemy import ColumnElement, and_, distinct, func, or_, select
from sqlalchemy import ColumnElement, and_, distinct, false, func, or_, select
from sqlalchemy.orm import Session
from sqlalchemy.sql.operators import ilike_op

Expand Down Expand Up @@ -163,6 +163,9 @@ def __separate_tags(
continue
case ConstraintType.Tag:
ids = self.__get_tag_ids(term.value)
if len(ids) == 0:
bool_expressions.append(false())
continue
if not only_single:
tag_ids.update(ids)
continue
Expand Down