feat: declare strict types in tests and use override attribute#207
Open
shakaran wants to merge 2 commits into
Open
feat: declare strict types in tests and use override attribute#207shakaran wants to merge 2 commits into
shakaran wants to merge 2 commits into
Conversation
sadikoff
reviewed
May 28, 2025
| public function registerContainerConfiguration(LoaderInterface $loader): void | ||
| { | ||
| if (null === $this->builder) { | ||
| if (!$this->builder instanceof \Symfony\Component\DependencyInjection\ContainerBuilder) { |
There was a problem hiding this comment.
we already have a use statement for it
|
Thanks for your work we really appreciate it, however as I mentioned in #173 looks like this bundle will not be maintained in that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.