feat: make signature generation more flexible by allowing relative URLs#142
Conversation
|
This configuration option would be great. I have a use case where I want to target to a completely different host running on another framework; the hosts endpoint then proxies the request (or rather re-creates it) to the Symfony Controller. |
|
@MichaelBrauner could you rebase for resolve the conflicts? Thanks |
b434387 to
93d5392
Compare
93d5392 to
90ec899
Compare
|
Hi, this PR is now ready for review. However, I wasn't able to run the test suite locally – vendor/bin/simple-phpunit fails with:
I tried with PHP 8.1 and 8.2, removed and reinstalled the vendor folder and the PHPUnit Bridge multiple times, but no success. Thanks! |
|
Can you rerun the checks? |
|
Sorry for the delay. I reran the CI, but we still have errors here |
|
@bocharsky-bw would you be so kind to re-run CI so that we can see the errors? The old logs have been archived. |
|
@melbings I reran the CI for you, I hope this helps! Though I see this PR now should be rebased due to some changes in master, and there are some conflicts that should be resolved too. UPD: Yeah, probably the conflicts should be resolved first. If you want to follow up on this PR and push it forward - please, feel free to create a new PR based on these changes |
|
@bocharsky-bw I'm afraid we're abandoning this pull request on our side. We will use Symfony's UriSigner component to deal with signed URLs instead. Nevertheless, thank you for your work and your support. |
|
@bocharsky-bw @jrushlow Any chance this can still be merged? |
I'm afraid that someone would need to resolve merge issues that have come up since we originally worked on this. Unfortunately, my company cannot work on this anymore. I assume that Claude & co. should have quite an easy time finishing this up, though. |
Here is the PR regarding this issue: #136
In the current implementation, the UriSigner always generates an absolute URL when signing. However, this might not be the desired behavior in some cases.
This PR adds a configuration option (use_relative_path) to allow the use of relative URLs when generating signatures. By default, the option is set to false, which maintains the existing behavior of generating absolute URLs.