Skip to content

Handle invalid prelaunch commands gracefully instead of fail_fast - #334

Open
DanielB-2 wants to merge 7 commits into
stagingfrom
db/handle-invalid-commands-gracefully
Open

DanielB-2 wants to merge 7 commits into
stagingfrom
db/handle-invalid-commands-gracefully

Conversation

@DanielB-2

@DanielB-2 DanielB-2 commented Sep 21, 2026 •

Copy link
Copy Markdown

Description

A brief description of the changes in the PR
Instead of calling error_fail_fast() upon invalid prelaunch commands flash the LED red and beep to warn the user. Updated prelaunch tests.

Issue Link

Closes #286

Testing

  • Passes existing automated tests
  • Automated tests modified
  • Manual test performed

Include any relevant test artifacts here.

AI Disclosure (Required)

  • Was an AI agent used to synthesize a significant portion of the submitted code?
  • Do you understand that you are responsible for your contributions, regardless of whether they are generated or hand-written?

Scope of AI assistance:
None used

Other

n/a

Reviewer Checklist

Standards

  • Follows FCF Architectural Standards
  • Follows SDR Coding Standards
  • Code complexity/function Size is minimized
  • Code is testable
  • Code is readable and commented properly
  • License terms are respected

Accuracy

  • Code implements the correct requirement (a.k.a. does the right thing)
  • Code is logically correct (a.k.a. does the thing right)

Error Handling

  • Potentially unsafe functions return a status code
  • Error returns properly handled
  • Fail-fast errors are only thrown when unsafe to continue software execution
  • Debug errors are thrown for exceptions where execution should still continue (to be noticed during development)

Memory

  • Stack allocated memory is scoped correctly
  • Heap allocated memory is not used
  • Statically/Globally allocated memory is minimized except when necessary
  • Pointers are used correctly
  • Concurrent access has been considered (especially by/from interrupt service routines)

Performance

  • Rate limiters are respected
  • Busy waiting is avoided in performance sensitive code
  • "Delay" calls are not used in performance sensitive code
  • If performance is negatively impacted, a justification is provided and the impact is quantified

@DanielB-2
DanielB-2 changed the base branch from main to staging September 22, 2026 02:46
@DanielB-2
DanielB-2 force-pushed the db/handle-invalid-commands-gracefully branch from 10cb511 to 32689b6 Compare September 26, 2026 18:27
@DanielB-2
DanielB-2 force-pushed the db/handle-invalid-commands-gracefully branch from 32689b6 to 9e7e076 Compare September 26, 2026 18:29
DanielB-2 added 2 commits September 26, 2026 16:57
@DanielB-2
DanielB-2 marked this pull request as ready for review September 29, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prelaunch/Terminal: Handle invalid commands gracefully

1 participant