Skip to content

Use rmcp object macro and cover discovery compatibility - #82

Merged
Subhransu-De merged 1 commit into
mainfrom
simplify-rmcp-objects
Oct 10, 2026
Merged

Subhransu-De merged 1 commit into
mainfrom
simplify-rmcp-objects

Conversation

@Subhransu-De

Copy link
Copy Markdown
Owner

What changed

After #81 upgrades rmcp from 3.5.0 to 3.5.1, use the SDK's object constructor
and cover its transport fixes in ControlFreak's own handler.

  • Replace the local JSON object conversion helper in schema.rs and its seven
    literal callers with rmcp::object!. Version 3.5.1 makes this macro available
    with our existing minimal feature set
    (upstream #1318).
    The generated tool schemas remain identical.
  • Add synthetic duplex transport coverage for discovery followed by classic
    initialization, recovery from malformed/unsupported bootstrap requests, and
    repeated discovery followed by inline requests
    (upstream #1248).
    These observations leave the control indicator dormant.
  • Verify modern tool lists receive conservative ttlMs: 0 and
    cacheScope: private hints, while legacy results omit modern fields
    (upstream #1308).
    Let the SDK provide these defaults.
  • Document the client-visible transport fixes in CHANGELOG.md.

The other release changes concern disabled HTTP/OAuth/procedural macro features,
upstream examples/CI, or an upstream resolver setting already used here. The
application error metadata and desktop cleanup wrappers remain necessary.

Checks

  • make check on Windows (formatting, Clippy, workspace tests, release
    server and installer builds)
  • Focused MCP protocol regression tests
  • Dependency lockfile scanned with OSV: no known vulnerabilities
  • Changed files checked with typos and staged changes scanned with gitleaks
  • User-visible changes are documented

The new protocol tests use a fake backend. Live capture, OCR, hardware input,
and multi-display behavior were not exercised.
Vale could not run because the repository has no .vale.ini configuration.


Model: gpt-6.1-sol

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T03:50:46.845768Z 3bf2bea PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Subhransu-De
Subhransu-De merged commit a33b5af into main Oct 10, 2026
7 checks passed
@Subhransu-De
Subhransu-De deleted the simplify-rmcp-objects branch October 10, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant