Repository navigation
Use rmcp object macro and cover discovery compatibility - #82
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
After #81 upgrades rmcp from 3.5.0 to 3.5.1, use the SDK's object constructor
and cover its transport fixes in ControlFreak's own handler.
schema.rsand its sevenliteral callers with
rmcp::object!. Version 3.5.1 makes this macro availablewith our existing minimal feature set
(upstream #1318).
The generated tool schemas remain identical.
initialization, recovery from malformed/unsupported bootstrap requests, and
repeated discovery followed by inline requests
(upstream #1248).
These observations leave the control indicator dormant.
ttlMs: 0andcacheScope: privatehints, while legacy results omit modern fields(upstream #1308).
Let the SDK provide these defaults.
CHANGELOG.md.The other release changes concern disabled HTTP/OAuth/procedural macro features,
upstream examples/CI, or an upstream resolver setting already used here. The
application error metadata and desktop cleanup wrappers remain necessary.
Checks
make checkon Windows (formatting, Clippy, workspace tests, releaseserver and installer builds)
The new protocol tests use a fake backend. Live capture, OCR, hardware input,
and multi-display behavior were not exercised.
Vale could not run because the repository has no
.vale.iniconfiguration.Model: gpt-6.1-sol