Repository navigation
Cover dependency protocol negotiation and JSONC newline fixes - #80
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
the synthetic user-stop transport test. Assert the negotiated version and keep
once-only notification, retained stop reason, and input refusal coverage under
a deadline. This covers the upstream protocol-version change
without adding a server configuration override.
endings. Assert comments, unrelated values, server entries, and line endings
survive. jsonc-parser 0.34.0 fixes lone-CR parsing and CST edits;
document the resulting behavior in the changelog. The parser migration in chore(deps): bump jsonc-parser from 0.33.2 to 0.34.0 #74
explicitly disables the newly permissive JSON5 switches.
channel, and timer fixes apply through the upgrade. Advanced JSON Schema,
rmcp HTTP/client/macros, and JSON5 features do not fit current call sites; no
custom implementation was made obsolete by these updates.
Checks
make check(formatting, Clippy, tests, and release build)documentation changes.
Vale could not run because no configuration is present.
Model: gpt-6.1-sol