Fix session isolation for remote browser WebSocket connections - #305
Merged
abrom merged 2 commits intoApr 2, 2026
Merged
Conversation
Contributor
|
Released in v1.2.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
browser_ws_endpointto connect to a remote Chrome instance, pages are created viabrowser.newPage()in the default browser context. Cookies (and other browsing state) set during one request persist in the default context and leak into subsequent requests from other users.This PR updates the behaviour to use
browser.createBrowserContext()instead. This behaves like an incognito session — state is fully isolated and automatically cleared whencontext.close()is called after the request completes.Added a test that:
evaluateOnNewDocumentWithout the fix, the second request sees
session-secret=abc123(bleed). With the fix it seesno cookies.