Skip to content

fix(core): resolve repository quality audit findings - #158

Merged
StudentWeis merged 2 commits into
mainfrom
fix/repository-quality-audit
Aug 5, 2026
Merged

fix(core): resolve repository quality audit findings#158
StudentWeis merged 2 commits into
mainfrom
fix/repository-quality-audit

Conversation

@StudentWeis

Copy link
Copy Markdown
Owner

Summary

Resolves every actionable finding from the repository-wide code, comment, and test-quality audit. The changes harden clipboard writes, platform activation, repository deletion, updater integrity, settings persistence, localization, documentation, and test isolation.

Linked Issue

Closes #157

Changes

  • Propagate clipboard write failures, distinguish rich-text payloads, and hash complete image identity.
  • Make repository deletion/cleanup/clear atomic across trees and defer sidecar removal until commit succeeds.
  • Remove unbounded X11 activation polling and identify the Ropy window specifically on Windows.
  • Require valid update checksums in manifests and downloads; save settings atomically without overwriting malformed configuration.
  • Isolate settings/autostart tests, localize file labels, and enforce warning-free Rustdoc in precheck.

Testing

  • scripts/precheck.sh passes locally
  • New / updated tests cover the change
  • 471 tests pass
  • RUSTDOCFLAGS="-D warnings" cargo doc --no-deps passes
  • Update manifest generation rejects missing checksums and accepts complete archive/checksum pairs

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis
StudentWeis merged commit d6fe133 into main Aug 5, 2026
8 checks passed
@StudentWeis
StudentWeis deleted the fix/repository-quality-audit branch August 5, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: resolve repository quality audit findings

1 participant