feat: Add workshop GetAddonContributions function#31
Open
Conversation
Member
|
I'd rather have something like this: Returning a full file listing from the addon would be extremely expensive both in terms of disk I/O and memory usage (because we'd need to store that file listing in memory). We could instead do some basic indexing like this: which would be reasonably fast, especially for packed addons. We cannot rely on the addons to self-report anything in their metadata either. |
Member
Author
|
That's fine, we just need some way to know what an addon contributes without relying on author-provided info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a function to list the files currently being provided by a given addon.