Skip to content

feat: Schema canonicalisation#1138

Draft
Stranger6667 wants to merge 17 commits into
masterfrom
canonical-schema-foundation
Draft

feat: Schema canonicalisation#1138
Stranger6667 wants to merge 17 commits into
masterfrom
canonical-schema-foundation

Conversation

@Stranger6667
Copy link
Copy Markdown
Owner

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 23, 2026

Merging this PR will not alter performance

✅ 78 untouched benchmarks
🆕 4 new benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 canonicalize/many_small_allofs_inside_object N/A 729.9 µs N/A
🆕 canonicalize/deep_allof_chain N/A 366.2 µs N/A
🆕 canonicalize/wide_anyof_in_allof N/A 281.7 µs N/A
🆕 canonicalize/object_with_properties N/A 93.5 µs N/A

Comparing canonical-schema-foundation (133ca02) with master (5e816f8)

Open in CodSpeed

@Stranger6667 Stranger6667 force-pushed the canonical-schema-foundation branch 21 times, most recently from 28183a2 to ccbd9c3 Compare May 24, 2026 11:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 88.91710% with 742 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.40%. Comparing base (5e816f8) to head (133ca02).

Files with missing lines Patch % Lines
crates/jsonschema/src/canonical/to_value.rs 84.94% 112 Missing ⚠️
crates/jsonschema/src/canonical/negate.rs 78.57% 108 Missing ⚠️
...jsonschema/src/canonical/normalization/collapse.rs 93.33% 55 Missing ⚠️
crates/jsonschema/src/canonical/intersect/mod.rs 84.83% 54 Missing ⚠️
crates/jsonschema/src/canonical/coverage.rs 84.64% 47 Missing ⚠️
crates/jsonschema/src/canonical/one_of.rs 51.64% 44 Missing ⚠️
...rates/jsonschema/src/canonical/intersect/number.rs 70.14% 40 Missing ⚠️
crates/jsonschema/src/canonical/parse.rs 95.38% 34 Missing ⚠️
.../jsonschema/src/canonical/normalization/numeric.rs 88.05% 32 Missing ⚠️
crates/jsonschema/src/canonical/cardinality.rs 89.86% 30 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   94.52%   93.40%   -1.13%     
==========================================
  Files          88      117      +29     
  Lines       24611    31281    +6670     
==========================================
+ Hits        23263    29217    +5954     
- Misses       1348     2064     +716     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stranger6667 Stranger6667 force-pushed the canonical-schema-foundation branch 7 times, most recently from 6d20080 to df79dc2 Compare May 24, 2026 16:46
@Stranger6667 Stranger6667 force-pushed the canonical-schema-foundation branch 7 times, most recently from 45a6327 to 7101dd5 Compare May 24, 2026 21:31
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
@Stranger6667 Stranger6667 force-pushed the canonical-schema-foundation branch from 06eec9a to 705bdfd Compare May 25, 2026 16:06
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant