fix: add heartbeat ping sweep and fix connection leak in WebSocket service#839
Merged
Mosas2000 merged 1 commit intoJul 20, 2026
Conversation
…rvice - Add pendingPing tracking to ClientState for protocol-level pong detection - Rewrite heartbeat to send pings every 30s and terminate clients that miss pong - Fix removeClient() to do soft removal instead of hard delete, preserving client state for heartbeat cleanup and resume functionality - Add ping/terminate to SocketConnection interface - Register socket pong/close handlers for liveness tracking - Add shutdown() method for clean interval teardown - Add 9 new tests covering heartbeat timeout, pong handling, close handling - Fix existing test assertions for empty topic subscriber cleanup Resolves StellaBridge#832
Alaka-ibr
pushed a commit
to Alaka-ibr/Bridge-Watch
that referenced
this pull request
Jul 21, 2026
…artbeat-timeout-disconnect fix: add heartbeat ping sweep and fix connection leak in WebSocket service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #832