Add allmazz/decky-volume-mixer#1019
Conversation
Issues Found
Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
fixed |
|
I would be glad to test it on SteamOS, but I do not have a Steam Deck. |
|
@allmazz Since this is a new plugin, please recruit a tester in our Discord server or elsewhere who can install and test this plugin on a Steam Deck. That is our primary userbase and any plugins on the store should generally work on Steam Decks unless very clearly intended for other devices. |
|
Sorry, I misremembered our requirements. It doesn't need to be tested on a Steam Deck, but you do need to test it on SteamOS in general. Please do that and we can move forward with the PR process! :) |
|
Confirming that this works on the Deck |
beebls
left a comment
There was a problem hiding this comment.
Code LGTM, just want a confirmation that the dependencies you mentioned needing (wpctl and pw-dump) are present on a stock Steam Deck, we don't want plugins that require users disabling read-only or otherwise modifying the system.
If you can confirm that those packages exist on a stock install then I'll get it off to testing.
Yes, they preinstalled since SteamOS uses pipewire with wireplumber and in Arch there is no separate package pipewire-tools like on Fedora. Kindly confirmed and tested by a discord server member. |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
Just realized this was never deployed to the testing store. Sorry about that! |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): Has the following minor non-blocking issue(s): SummaryNo noticeable issues with the plugin. Audio gets changed as expected and boost limit allows to boosting the audio. I did not test the regex excludes. |
|
You have merge conflicts and we aren't authorized to update the PR, please rebase to fix the conflicts |
b4390fd to
3bf361a
Compare
done |
|
Off to testing store now, just gonna need one more testing report saying that the testing store version itself works and then we can merge it (you can even get the same user from before to check again) |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None SummaryWorks as documented, no issues at all. |
Add Mixer to Plugin Store
A configurable plugin that allows you to quickly control the volume of your applications.
There is similar plugin named "Volume Mixer", but it uses pactl instead of pipewire with wireplumber and not configurable.
Task Checklist
Developer
Plugin
Backend
Community
Testing