Added functionality to open file from assets#301
Conversation
lrasmus
left a comment
lrasmus
left a comment
There was a problem hiding this comment.
Looking really good overall - sorry for the delay to look at this. More detail in the tagged comment about possible changes. Thanks!
| if (asset) { | ||
| const filePath = asset.uri; | ||
| if (filePath) { | ||
| fileActions = ( |
There was a problem hiding this comment.
Could we make a few modifications to the available actions here? One of these is a new request I did not think of originally, so it can be considered out of scope.
- For a folder, "Open File" works, but does the same action as "Show in Folder". We should hide the "Open File" action if the asset type is a folder
- For external resources, these options should not be available
- (New request) For external resources, because those would be a URL, the action could be "Open URL" or "Open Link"
If possible to address 1 & 2 in this PR, that would be great. Item 3 is expanding the scope of this request, but if you would be willing to tackle it that would be awesome.
There was a problem hiding this comment.
Sure sir, I will fix this ASAP!!
Thanks :)
lrasmus
left a comment
lrasmus
left a comment
There was a problem hiding this comment.
Will accept as is (thank you for the implementation!) and open new issues to resolve the related requests that I had made.
2 participants
Fixed Issue #290
Similar Functionality as Show in folder and Open file in Search feature