Draft
Conversation
Changes: - add and in to support process stopping, update relative initialization - implement and function for process continuation and stoppage in - implement function to actually use the Poll mechanism implement stopping for processes in - update function in to check for SIGCONT under different scenarios, ensure the continuation of a stopped process regardless its signal mask and disposition settings - update function in to call and to respond to the signal.
… avoid blocking forever when SIGKILL or SIGCONT is only sent to a thread; update some comments
Changes: - Revert the design that tracking stop signals in ProcessData. Move it to ProccessSignalManager - Move zombie state transition from Process::exit to do_exit for single reponsibility - Integrate stop/continue signal reporting mechanism into do_stop and do_continue function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
stop_eventandstop_signalinProcessDatato support process stopping, update relative initializationdo_continueanddo_stopfunction for process continuation and stoppage inapi/src/task.rshandle_stopped_statefunction to actually use the Poll mechanism implement stopping for processes inapi/src/task.rscheck_signalsfunction inapi/src/signal.rsto check for SIGCONT under different scenarios, ensure the continuation of a stopped process regardless its signal mask and disposition settingscheck_signalsfunction inapi/src/signal.rsto calldo_stopanddo_continueto respond to the signal.Related