Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to adapt to changes in the axtask module API (arceos PR #19), updating task extension types and async polling patterns throughout the system.
- Renamed
TaskExtProxytoAxTaskExtacross task creation code - Replaced
PollerAPI with newpoll_ioandblock_onfunctions for async I/O operations - Updated
spawncalls tospawn_with_namewhere task names are provided - Added
.unwrap()totask.join()call to handle new return type
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/entry.rs | Updated task extension type and added unwrap to join call |
| core/src/config/*.rs | Reformatted kernel stack size constant with underscore separator |
| arceos | Updated submodule commit reference |
| api/src/vfs/dev/tty/ntty.rs | Changed IRQ waker registration import path |
| api/src/vfs/dev/tty.rs | Migrated from Poller to poll_io/block_on pattern |
| api/src/vfs/dev/log.rs | Updated spawn to spawn_with_name |
| api/src/vfs/dev/fb.rs | Updated spawn to spawn_with_name |
| api/src/terminal/ldisc.rs | Migrated polling logic to poll_io/block_on pattern |
| api/src/syscall/task/clone.rs | Updated task extension type name |
| api/src/syscall/io_mpx/*.rs | Migrated select/poll/epoll from Poller to timeout+poll_io pattern |
| api/src/file/*.rs | Migrated file I/O operations from Poller to poll_io/block_on pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to Starry-OS/arceos#19.
This is in preparation for a smoother transition to the new version of arceos.