fix: handle non-numeric manifest icon keys in get_extension_icon to prevent ValueError crash#133
Closed
Copilot wants to merge 1 commit into
Closed
fix: handle non-numeric manifest icon keys in get_extension_icon to prevent ValueError crash#133Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/Stanzin7/ExtensionShield/sessions/9a40453e-b2da-4482-b112-f6bd06e51721 Co-authored-by: sapnilbiswas <230308982+sapnilbiswas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sapnilbiswas
April 4, 2026 09:10
View session
sapnilbiswas
approved these changes
Apr 4, 2026
sapnilbiswas
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131
Summary
get_extension_iconcrashed withValueErrorwhen a Chrome extension manifest'siconsobject contained non-numeric keys (e.g."48x48","icon") instead of pure integer strings like"48".Root cause:
max(manifest_icons.keys(), key=lambda x: int(x))—int("48x48")raisesValueError.Changes
k.isdigit()before callingmax()if numeric_keys:so manifests with no numeric icon keys are skipped gracefully, falling through to the existing persisted-icon → placeholder fallback chainkey=lambda x: int(x)→key=intReview of PR #132
PR #132 (by @Th-Shivam) correctly identifies and targets the same bug. However, it has three issues this PR addresses:
ValueError(caught by outerexcept Exception, logs misleading warning)if numeric_keys:isinstance(k, str)guardjson.loadalways produces string keys)key=lambda x: int(x)key=intTesting