Miscellaneous updates#1
Open
sol-mocha wants to merge 7 commits intoSquads-Protocol:mainfrom
Open
Conversation
sol-mocha
commented
Mar 4, 2024
| branding: | ||
| icon: "upload" | ||
| color: "black" | ||
| color: "gray-dark" |
Author
There was a problem hiding this comment.
Apparently black is not a valid value.
https://json.schemastore.org/github-action.json
sol-mocha
commented
Mar 4, 2024
| { | ||
| "name": "squads-v4-program-upgrade", | ||
| "main": "lib/main.js", | ||
| "private": false, |
sol-mocha
commented
Mar 4, 2024
| "dependencies": { | ||
| "@actions/core": "^1.10.1", | ||
| "@marinade.finance/marinade-ts-sdk": "^5.0.6", | ||
| "@coral-xyz/anchor": "^0.29.0", |
Author
There was a problem hiding this comment.
Was referenced in utils but not added as a dep.
sol-mocha
commented
Mar 4, 2024
| "@coral-xyz/anchor": "^0.29.0", | ||
| "@solana/web3.js": "^1.78.4", | ||
| "@sqds/multisig": "^1.9.0", | ||
| "bn.js": "^5.2.1", |
Author
There was a problem hiding this comment.
No reason to add all the bloat of @marinade.finance/marinade-ts-sdk just for bn.js.
This package was added just for BN. This commit directly adds BN as a dep.
Contributor
|
@sol-mocha Have you been able to build this ? (yarn build) |
Author
Seems to build just fine, or is another output expected? 
|
Author
Hey @valentinmadrid curious on your thoughts for this PR. Any requested changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous updates:
bn.jsas a dep directlypackage.json