Add qualitymetrics curation #4365
Open
+152
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
reviewed
Feb 3, 2026
chrishalcrow
reviewed
Feb 3, 2026
|
My kind of high level idea was people can add or remove threshold in the bombcell_label_units and that is then equivalent to this (if people set thresholds to none for metrics other than fr and snr) but people also get the output plots spit out and (eventually) the integration in the GUI. We could call bombcell just " quality metrics" and then have everything alltogether - does it make sense to duplicate things or am I missing how this is different? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of
model_based_label_unitsandbombcell_label_units, this PR addsqualitymetrics_label_units