to_pynapple_tsgroup : attach_unit_properties, export sorting properties #4360
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option to attach unit properties from sorting to the TsGroup object.
for more information, see https://pre-commit.ci
chrishalcrow
reviewed
Feb 2, 2026
chrishalcrow
reviewed
Feb 2, 2026
chrishalcrow
reviewed
Feb 2, 2026
Changed attach_unit_properties to True by default and updated property_data assignment to convert to list.
Member
|
Cool! |
chrishalcrow
reviewed
Feb 3, 2026
Comment on lines
+89
to
+92
| for property_key in property_keys: # loop through sorting's properties | ||
| property_data = sorting.get_property(property_key) | ||
| property_df[property_key] = list(property_data) | ||
| metadata_list.append(property_df) |
Member
There was a problem hiding this comment.
The tests are failing when there are no sorting properties. I would put these four lines inside a if len(property_keys) > 0, so that the metadata_list is only updated if there are some property keys.
chrishalcrow
reviewed
Feb 3, 2026
| # Look for good metadata to add, if there is a sorting analyzer | ||
| if attach_unit_metadata and isinstance(sorting_analyzer_or_sorting, SortingAnalyzer): | ||
|
|
||
| metadata_list = [] |
Member
There was a problem hiding this comment.
Suggested change
I noticed that this metadata_list = [] is not needed! A bug from me when I first coded this. Could you remove it please - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to attach unit properties from sorting to the TsGroup object.
#4346