Skip to content

Harmonization of the way we are computing sliding_rp_violations #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yger wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −14
Open

Harmonization of the way we are computing sliding_rp_violations #4324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dbdce1
WIP
yger Jan 16, 2026
62ab292
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions src/spikeinterface/metrics/quality/misc_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,21 +1491,9 @@ def slidingRP_violations(

method = "numba" if HAVE_NUMBA else "numpy"

bin_size = max(int(bin_size_ms / 1000 * sorting.sampling_frequency), 1)
window_size = int(window_size_s * sorting.sampling_frequency)
from spikeinterface.postprocessing.correlograms import compute_correlograms

if method == "numpy":
from spikeinterface.postprocessing.correlograms import _compute_correlograms_numpy

correlogram = _compute_correlograms_numpy(sorting, window_size, bin_size)[0, 0]
if method == "numba":
from spikeinterface.postprocessing.correlograms import _compute_correlograms_numba

correlogram = _compute_correlograms_numba(sorting, window_size, bin_size)[0, 0]

## I dont get why this line is not giving exactly the same result as the correlogram function. I would question
# the choice of the bin_size above, but I am not the author of the code...
# correlogram = compute_correlograms(sorting, 2*window_size_s*1000, bin_size_ms, method=method)[0][0, 0]
correlogram = compute_correlograms(sorting, 2 * window_size_s * 1000, bin_size_ms, method=method)[0][0, 0]
correlogram_positive = correlogram[len(correlogram) // 2 :]

conf_matrix = _compute_violations(
Expand Down
Loading