Repository navigation
feat: show messages from the voice channel's text chat - #97
Conversation
eb966b1 to
4c6d62d
Compare
Adds the Show Voice Channel Chat setting and builds read-only rows from voice channel chat messages. avatar_url moves to orbolay-core so chat rows and the voice list share it.
Chat rows show next to notifications with the channel name ({{channel}}).
Template tokens are now replaced in one pass, so message text can't expand
them.
Orbolay tells each bridge when to forward chat (SET_VOICE_CHANNEL_CHAT) and receives VOICE_CHANNEL_MESSAGE.
Subscribes to MESSAGE_CREATE for the current voice channel while the setting is on.
Chat rows and the IPC voice list now pick names the same way: nickname, then display name, then username, skipping empty ones.
44712fa to
d49cdba
Compare
|
Sorry for the wait, I've been quite ill, I will take a look at these as soon as I can 👍 |
SpikeHD
left a comment
SpikeHD
left a comment
There was a problem hiding this comment.
looks good! one thing is that i think id prefer if we can unify the two notification types to look exactly the same, is it possible to implement? i don't mind which of the two "designs" are used (i do like the semi-dark look of channel_name, though it doesn't show the guild name), but they look a bit out of place next to eachother, even though they signal the same thing
|
@SpikeHD Thanks! I went with the top one, so chat rows now get the same title as other notifications, e.g. The bridges need to send the server name for this, so I opened SpikeHD/vc-orbolay-bridge#9 and SpikeHD/shelter-plugins#123. Over IPC Orbolay already knows it. |
|
perfect thanks :) one final note: can we remove the "#" on voice channels? identically named channels look misleading otherwise haha |
|
perfect, thank you! |
Closes #96
Adds a Show Voice Channel Chat setting (Notifications, off by default). While it's on, new messages in your voice channel's text chat show up like notifications, titled the same way (
Alex (General, Game Night), no#since it is a voice channel).MESSAGE_CREATEfor the current voice channel while the setting is on. No new scopes.SET_VOICE_CHANNEL_CHAT {enabled}and the bridges forward messages asVOICE_CHANNEL_MESSAGE(happy to rename these). Older versions on either side just don't show chat.Bridges: SpikeHD/vc-orbolay-bridge#8, SpikeHD/vc-orbolay-bridge#9, SpikeHD/shelter-plugins#122, SpikeHD/shelter-plugins#123 (Equicord to follow)
Tested on Windows with the official client, Equibop and Vesktop. I don't have a second account, so I used my own messages with a local change, and a fake websocket client for other users.
cargo fmtandclippypass.