Fixes to Convolutions#1286
Merged
Merged
Conversation
Arbitrary size of convolution kernels (including non-square, non-odd sized) Strides, in particular non-square Fixed [row, column] order on convolution parameters (eg. padding and strides), in line with documentation comments
Contributor
|
This ought to be checked with regard to the KernelConnector as well (both the python implementation and the C implementation in the synapse expander), as I think both of them started from the same codebase. |
Member
|
This was merged into a BRANCH only. See #1294 to merge into master. |
Member
Author
|
We are discussing locally. Do you have a reasonably simple network we could use as a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/emijan-kth/sPyNNaker/blob/convolution_fixes_description/conv_changes.md