Skip to content

chore(alerts): remove alerts constant from BHCE BED-9448 - #3193

Open
sirisjo wants to merge 1 commit into
mainfrom
BED-9448
Open

chore(alerts): remove alerts constant from BHCE BED-9448#3193
sirisjo wants to merge 1 commit into
mainfrom
BED-9448

Conversation

@sirisjo

@sirisjo sirisjo commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

This const should live in BHE, where it is used, according to the new slice architecture.

Motivation and Context

Resolves BED-9448

How Has This Been Tested?

No tests needed.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

Summary by CodeRabbit

  • Refactor
    • Removed an unused alert webhook identifier path parameter from the API.

@sirisjo sirisjo self-assigned this Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 62c13d17-6fc2-4c63-b7fe-edf91680dfb9

📥 Commits

Reviewing files that changed from the base of the PR and between 86011f2 and 9330778.

📒 Files selected for processing (1)
  • cmd/api/src/api/constant.go
💤 Files with no reviewable changes (1)
  • cmd/api/src/api/constant.go

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The API constants no longer export URIPathVariableAlertWebhookID, which represented the alert_webhook_id URI path parameter.

Changes

Alert webhook constant cleanup

Layer / File(s) Summary
Remove alert webhook URI constant
cmd/api/src/api/constant.go
Removes the exported URIPathVariableAlertWebhookID constant.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 93307

This is a localized cleanup that removes an unused constant without evidence of a user-facing or production-impacting change; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of the alerts constant and includes the related ticket.
Description check ✅ Passed The description includes the change, motivation, ticket, testing statement, change type, and completed checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-9448

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant