feat: Display privilege zone graph context - #3150
Draft
justin-prime1 wants to merge 5 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intent
Add the shared graph, Search, ETAC, and Explore behavior needed to consume Enterprise Privilege Zone graph context consistently with ordinary graph entities.
Implementation
PZnode kinds without a special search path.Blast Radius / Risk
Shared Search, graph conversion, unified graph, ETAC, and Explore detail paths change only for
PZ_PrivilegeZone,PZ_PrivilegeZoneEnvironment,PZ_InZone, andPZ_PartOfZone. An ETAC defect could hide authorized context or expose canonical context without an authorized environment; focused tests cover both directions. BHCE adds no producer, migration, or standalone CE analysis behavior.BHE/BHCE Parity
matchedfor shared graph behavior; the paired BHE runtime producer is intentionally Enterprise-only.Reviewability / Reviewer Brief
Review size: 446 reviewable changed lines — 109 product and 337 tests. The author approved this cohesive Search/conversion/ETAC/UI exception over 400 lines; reviewer agreement is still required. Suggested order: ETAC; API conversions; Search; shared UI formatting; tests.
Test Changes
Added or updated tests for uppercase names, normalized Search, relationship labels, graph conversion, authorized/unauthorized canonical-zone ETAC behavior, PZ-specific property labels, and preservation of generic formatting. No tests were removed or weakened.
Rollback
After reverting the paired BHE producer, revert this BHCE PR. BHCE has no migration or persisted-data change. Reverting BHCE first would leave generated PZ entities without intended Search, ETAC, and display handling.
Motivation and Context
Enterprise materializes Privilege Zone graph objects; shared BHCE layers must render, search, traverse, and authorize them consistently. No Jira or GitHub issue is associated with this prototype, by author request.
Resolves N/A — prototype authorized without a ticket.
How Has This Been Tested?
Validation / Evidence
At BHCE
09e0f244ebe61914a9d2772990c733a41acac834and paired BHEf2a35cf75a8f1ed552fe4f760d64af38e7ab0bc7:just prepare-for-codereview, parity, and enterprise review passed.Explicitly Not Validated
mainmovement; this draft branch is one commit behind livemainand must be refreshed before readiness.Screenshots (optional):
Types of changes
Checklist: