Do not emit warning about failed height query immediately - #8
Open
citizen-stig wants to merge 1 commit into
Open
Do not emit warning about failed height query immediately#8citizen-stig wants to merge 1 commit into
citizen-stig wants to merge 1 commit into
Conversation
But only after a while
theodorebugnet
approved these changes
Jun 12, 2026
theodorebugnet
left a comment
theodorebugnet
left a comment
Collaborator
There was a problem hiding this comment.
It might be better to only suppress the warnings specifically around startup or near the shutdown height. But in practice if the rollup fails, the process will usually exit and we'll catch it anyway (I don't think we've ever seen the rollup become unresponsive to height queries while still running fine).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But only after a while