Update SQL view to use new data source by julianostefano · Pull Request #230 · Snowflake-Labs/advanced-data-engineering-snowflake

julianostefano · 2026-08-28T17:19:57Z

This pull request updates the data source references in the weather data pipeline to ensure consistency and correctness. The main change is switching the schema used for weather source tables in the views.sql file.

Data source updates:

Changed the schema in the FROM and JOIN clauses from WEATHER_SOURCE_LLC_FROSTBYTE to FROSTBYTE_WEATHERSOURCE for the history_day and postal_codes tables in views.sql.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

Fix missing data

Add GitHub Actions workflow for data environment deployment

Staging

arcticowl-ai-review-labs · 2026-08-28T19:45:19Z

+    env:
+      # Read connection secret
+      SNOWFLAKE_CONNECTIONS_ADVANCED_DATA_ENGINEERING_SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
+      SNOWFLAKE_CONNECTIONS_ADVANCED_DATA_ENGINEERING_SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
+      SNOWFLAKE_CONNECTIONS_ADVANCED_DATA_ENGINEERING_SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}


🚨 Critical blocker

🔴 HIGH · Deploy workflow runs on merged PRs from forks/branches and executes repo-controlled SQL with production Snowflake secret · CWE-829

How to override this blocker

Resolve the finding and push, or override it:

On this comment: add a 👎 reaction and post an inline reply disputing it.

Add the critical_blocker_force_override label to the PR to trigger re-evaluation.

Every Critical blocker on the PR must be disputed this way — the label on its own does not override a blocker that has no 👎 and reply.

✅ Resolved — no longer active on the latest commit.

Fix syntax in GitHub Actions workflow for deployment

Staging

Fix missing data and CI

arcticowl-ai-review-labs · 2026-08-28T19:54:41Z

+on:
+  pull_request:
+    types: [closed]
+    branches:
+      - staging
+      - main
+  push:
+    branches:
+      - staging
+      - main
+
+jobs:
+  deploy_data_environment:
+    # Only run when PR is merged or on direct push to environment branches
+    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.merged == true)


🚨 Critical blocker

🔴 HIGH · GitHub Actions workflow runs on pull_request:closed with merge gate but exposes Snowflake prod credentials to fork/branc · CWE-94

How to override this blocker

Resolve the finding and push, or override it:

On this comment: add a 👎 reaction and post an inline reply disputing it.

Add the critical_blocker_force_override label to the PR to trigger re-evaluation.

Every Critical blocker on the PR must be disputed this way — the label on its own does not override a blocker that has no 👎 and reply.

✅ Resolved — no longer active on the latest commit.

Fix missing data 3

Fix missing data 4

Fix missing data 5

Fix missing data 6

Staging

Fix missing data 7

arcticowl-ai-review-labs · 2026-08-28T20:20:46Z

+    env:
+      # Read connection secret
+      SNOWFLAKE_CONNECTIONS_ADVANCED_DATA_ENGINEERING_SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
+      SNOWFLAKE_CONNECTIONS_ADVANCED_DATA_ENGINEERING_SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
+      SNOWFLAKE_CONNECTIONS_ADVANCED_DATA_ENGINEERING_SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}


🟠 MEDIUM · GitHub Actions workflow uses long-lived Snowflake password credential (ACCOUNTADMIN) with no rotation/least-privilege [N · CWE-798

Staging

arcticowl-ai-review-labs · 2026-08-28T20:40:24Z

+      - name: Deploy templates to data environment
+        run: |
+          # Export TARGET_BRANCH for use in this step
+          echo "Using branch: ${GITHUB_REF_NAME}"


🚨 Critical blocker

🔴 HIGH · Untrusted GITHUB_REF_NAME interpolated into snow git execute shell command enables command injection [NEW] · CWE-78

How to override this blocker

Resolve the finding and push, or override it:

On this comment: add a 👎 reaction and post an inline reply disputing it.

Add the critical_blocker_force_override label to the PR to trigger re-evaluation.

Every Critical blocker on the PR must be disputed this way — the label on its own does not override a blocker that has no 👎 and reply.

Update SQL view to use new data source

f96359f

Copilot AI lite review requested due to automatic review settings August 28, 2026 17:19

Copilot AI reviewed Aug 28, 2026

snowflake-security-bot Bot reviewed Aug 28, 2026

View reviewed changes

julianostefano added 6 commits August 28, 2026 16:01

Fix missing data

cd42a10

Merge pull request #1 from julianostefano/fix-missing-data

4456640

Fix missing data

Add GitHub Actions workflow for data environment deployment

6b66877

Merge pull request #2 from julianostefano/julianostefano-patch-1

dd9019e

Add GitHub Actions workflow for data environment deployment

Merge pull request #3 from julianostefano/staging

de6adc8

Staging

Fix syntax in GitHub Actions workflow for deployment

2b1512e

arcticowl-ai-review-labs Bot reviewed Aug 28, 2026

View reviewed changes

julianostefano added 4 commits August 28, 2026 16:45

Merge pull request #4 from julianostefano/julianostefano-patch-2

eee2caf

Fix syntax in GitHub Actions workflow for deployment

Merge pull request #5 from julianostefano/staging

dbda287

Staging

Fix missing data and CI

52e5f04

Merge pull request #6 from julianostefano/fix-missing-data

2e615fc

Fix missing data and CI

arcticowl-ai-review-labs Bot reviewed Aug 28, 2026

View reviewed changes

julianostefano added 11 commits August 28, 2026 16:57

Fix missing data 3

a2b9970

Merge pull request #8 from julianostefano/fix-missing-data

5105b96

Fix missing data 3

Fix missing data 4

cb5dc3f

Merge pull request #9 from julianostefano/fix-missing-data

a406ca1

Fix missing data 4

Fix missing data 5

63ccdab

Merge pull request #10 from julianostefano/fix-missing-data

0b387a4

Fix missing data 5

Fix missing data 6

9212531

Merge pull request #11 from julianostefano/fix-missing-data

6aeef2f

Fix missing data 6

Merge pull request #7 from julianostefano/staging

59a7564

Staging

Fix missing data 7

46caefb

Merge pull request #12 from julianostefano/fix-missing-data

3ab4ab1

Fix missing data 7

arcticowl-ai-review-labs Bot reviewed Aug 28, 2026

View reviewed changes

Merge pull request #13 from julianostefano/staging

079063f

Staging

arcticowl-ai-review-labs Bot reviewed Aug 28, 2026

View reviewed changes

Navigation Menu

Update SQL view to use new data source - #230

Update SQL view to use new data source#230
julianostefano wants to merge 23 commits into
Snowflake-Labs:mainfrom
julianostefano:main

julianostefano commented Aug 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026 •

edited

Loading

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026 •

edited

Loading

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

julianostefano commented Aug 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

arcticowl-ai-review-labs Bot Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arcticowl-ai-review-labs Bot Aug 28, 2026 •

edited

Loading

arcticowl-ai-review-labs Bot Aug 28, 2026 •

edited

Loading